LINQ使えば簡単だな

public static IEnumerable<TSource> Shuffle<TSource>(this IEnumerable<TSource> source) {
  var r = new Random();
  return source.OrderBy(x => r.NextDouble());
}